Bug in NVIDIA_nforce-1.0-0261.tar.gz

[jcdutton]

In nforce/nvaudio/nvspdif.c there is this code: -
void start_spdif(struct Nvaudio_state *state)
{
unsigned long flags;
spin_lock_irqsave(&state->lock, flags);
start_spdif(state);
spin_unlock_irqrestore(&state->lock, flags);
}

Which is obviously wrong, as it will just lock up.
A diff fix would be: -
--- nvspdif.c.org 2004-01-28 15:28:28.977486392 +0000
+++ nvspdif.c 2004-01-28 15:28:38.902977488 +0000
@@ -132,7 +132,7 @@
{
unsigned long flags;
spin_lock_irqsave(&state->lock, flags);
- start_spdif(state);
+ __start_spdif(state);
spin_unlock_irqrestore(&state->lock, flags);
}

[sphincter]

hmmm... bugs? Ya think?


make
make nvaudio.o
make[1]: Entering directory `/usr/src/nvidia/nforce/nvaudio'
cc -D__KERNEL__ -I/lib/modules/2.4.22-1.2149.nptl/build/include -Wall -Wstrict-prototypes -O -fno-strict-aliasing -mpreferred-stack-boundary=2 -march=i686 -falign-functions=4 -DMODULE -DMODVERSIONS -include /lib/modules/2.4.22-1.2149.nptl/build/include/linux/modversions.h -c -o nvhw.o nvhw.c
cc -D__KERNEL__ -I/lib/modules/2.4.22-1.2149.nptl/build/include -Wall -Wstrict-prototypes -O -fno-strict-aliasing -mpreferred-stack-boundary=2 -march=i686 -falign-functions=4 -DMODULE -DMODVERSIONS -include /lib/modules/2.4.22-1.2149.nptl/build/include/linux/modversions.h -c -o nvrec.o nvrec.c
In file included from nvhw.h:14,
from nvrec.c:12:
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:83:24: exponent has no digits
In file included from nvhw.h:14,
from nvrec.c:12:
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:83: error: syntax error before numeric constant
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:83: warning: function declaration isn't a prototype
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:84:24: exponent has no digits
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:84: error: syntax error before numeric constant
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:84: warning: function declaration isn't a prototype
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:88: error: `check_resource_R_ver_str' declared as function returning a function
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:88: warning: parameter names (without types) in function declaration
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:89:12: invalid suffix "cfb" on integer constant
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:89: error: syntax error before numeric constant
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:89: error: `request_resource_R_ver_str' declared as function returning a function
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:89: warning: function declaration isn't a prototype
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:90:26: invalid suffix "aec8c42" on integer constant
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:90: error: syntax error before numeric constant
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:90: error: `____request_resource_R_ver_str' declared as function returning a function
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:90: warning: function declaration isn't a prototype
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:91: error: syntax error before numeric constant
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:91: error: `release_resource_R_ver_str' declared as function returning a function
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:91: warning: function declaration isn't a prototype
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:98: error: `allocate_resource_R_ver_str' declared as function returning a function
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:98: warning: parameter names (without types) in function declaration
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:104:26: invalid suffix "a1a4f09" on integer constant
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:104: error: syntax error before numeric constant
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:104: error: `__request_region_R_ver_str' declared as function returning a function
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:104: warning: function declaration isn't a prototype
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:112: error: `__check_region_R_ver_str' declared as function returning a function
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:112: warning: parameter names (without types) in function declaration
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:113: error: `__release_region_R_ver_str' declared as function returning a function
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:113: warning: parameter names (without types) in function declaration
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:119:13: invalid suffix "a5a2280" on integer constant
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:119: error: syntax error before numeric constant
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:119: error: `autoirq_setup_R_ver_str' declared as function returning a function
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:119: warning: function declaration isn't a prototype
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:120:12: invalid suffix "c53" on integer constant
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:120: error: syntax error before numeric constant
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:120: error: `autoirq_report_R_ver_str' declared as function returning a function
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/ioport.h:120: warning: function declaration isn't a prototype
In file included from nvhw.h:15,
from nvrec.c:12:
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/sched.h:6:22: invalid suffix "b16c344" on integer constant
In file included from nvhw.h:15,
from nvrec.c:12:
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/sched.h:6: error: syntax error before numeric constant
/lib/modules/2.4.22-1.2149.nptl/build/include/linux/sched.h:6: warning: function declaration isn't a prototype
make[1]: *** [nvrec.o] Error 1
make[1]: Leaving directory `/usr/src/nvidia/nforce/nvaudio'
make: *** [all] Error 2


I'd just like to get it to compile.

[jcdutton]

I recommend using the alsa drivers instead if it is sound that you want.