View Single Post
Old 04-28-09, 06:26 AM   #2
NvFuchs
Registered Fox
 
NvFuchs's Avatar
 
Join Date: Oct 2007
Location: Confoederatio Helvetica
Posts: 530
Default Re: Easy nVidia driver update and installation

Sorry, but this is a rather bad idea from so many different point of views ...

(List is not complete, but these are probably the worst issues)

First of all, the script is not dynamic at all.
As you say by yourself, it is only for gdm, plus for distributions that have a /etc/init.d/gdm

Then: You are using sudo in the file, even though

a) sudo is not available on all distributions
b) sudo probably prompts for a password for most of the actions

You say that you run this script already with sudo, so all the sudos used are nonsense anyway.

It is a security risk, as you assume that the right binaries are the first ones taken from $PATH, and you are using too much wildcards in my opinion.

You have no shebang line, so you have to tell the script which interpreter it has to use.

There are errors in the script, you start gdm twice in the worst case. (Which, depending on gdm, will even work, but create something the user doesn't want)

And, most of all: Installing the driver that way fails on the most popular distributions. Even worse, it will break up the system at least on *Ubuntu, SuSE and Fedora, as there are additional steps are necessary.

Fuchs

Last edited by NvFuchs; 04-29-09 at 02:40 PM.
NvFuchs is offline   Reply With Quote