View Single Post
Old 06-16-10, 10:38 AM   #4
zander
NVIDIA Corporation
 
zander's Avatar
 
Join Date: Aug 2002
Posts: 3,740
Default Re: [PATCH] Fix parameter ordering in acpi_walk_namespace

I should note that the current version should not really have functional fallout: in 195.36.xx release builds (i.e. without DEBUG #defined), NV_ACPI_WALK_NAMESPACE() is only invoked as follows:
NV_ACPI_WALK_NAMESPACE(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
ACPI_UINT32_MAX, nv_acpi_find_methods, NULL, NULL);
Given the current implementation of NV_ACPI_WALK_NAMESPACE() for Linux 2.6.33+, this translates to the following acpi_walk_namespace() call:
acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
ACPI_UINT32_MAX, nv_acpi_find_methods, NULL, NULL, NULL);
Since both the context and return_value arguments are NULL, the current and the fixed versions of NV_ACPI_WALK_NAMESPACE() expand to the same call.
zander is offline   Reply With Quote