Go Back   nV News Forums > Linux Support Forums > NVIDIA Linux

Newegg Daily Deals

Thread Tools
Old 06-20-09, 01:04 PM   #1
Registered User
Join Date: Jul 2008
Posts: 7
Default New breakage from Linus (nv-i2c.c)

commit 352da9820e5506e3b8496e6052a2ad9c488efae8
Author: Jean Delvare <khali@xxxxxxx>
Date: Fri Jun 19 16:58:17 2009 +0200

i2c: Kill client_register and client_unregister methods

These methods were useful in the legacy binding model but no longer in
the new (standard) binding model. There are no users left so we can
drop them.

But those two methods are still used in nv-i2c.c:244,5

struct i2c_adapter nv_i2c_adapter_prototype = {
.owner = THIS_MODULE,
.algo = &nv_i2c_algo,
.algo_data = NULL,
.client_register = nv_i2c_adapter_register_client, <======
.client_unregister = nv_i2c_adapter_unregister_client, <======

I tried deleting those two lines, and the code compiles but modprobe
fails to install the module.

Anyone know the right fix?
wa1ter is offline   Reply With Quote
Old 06-20-09, 01:26 PM   #2
Registered User
Join Date: May 2006
Posts: 477
Default Re: New breakage from Linus (nv-i2c.c)

Use the new (standard) binding model calls? I'm not sure what they are, but do you know them?
mooninite is offline   Reply With Quote
Old 06-21-09, 07:02 AM   #3
Registered User
Join Date: Jul 2008
Posts: 7
Default Re: New breakage from Linus (nv-i2c.c)

Ugh. Linus just changed agp.h and broke more code in os-agp.c so I
give up debugging code I don't understand. I hope the devs here fix it quickly.
wa1ter is offline   Reply With Quote
Old 06-22-09, 06:47 AM   #4
Great Old One
cthulhu's Avatar
Join Date: Sep 2002
Posts: 124
Default Re: New breakage from Linus (nv-i2c.c)

I hope the good folks at nvidia have a new driver which support the new i2c model in the works. They should be aware that this change was coming, if they follow the kernel development.
I've been bitten by this "bug" as well on 2.6.30-git18 (upgraded from 2.6.30-git14, that works with the nvidia driver, so I don't know exactly when support for the old model was dropped).

EDIT: Just checked. There's a guide for upgrading i2c clients in the kernel documentation (<kernel src-dir>/Documentation/i2c/upgrading-clients).
Desktop: Asus P5B Deluxe, Core2Duo E8500, 2GB Corsair 800MHz CL4, Gigabyte GTX460 1024MB
HTPC: Asus P5B-E, Core2Duo 6300, 1GB Corsair 533MHz, Asus 9500GT w/ 512MB DDR3
Server: Gigabyte D510UD, Atom D510, 2GB Corsair 800MHz, Hauppauge NOVA-T500 dual DVB-T tuner, 4x 2TB Samsung F3EG (RAID5)
Laptop: Asus U6V, Core2Duo P8400, 3GB DDR2, 9300M GS
OS on all: Gentoo Linux

Bought a computer bundled with windows? Don't want to use windows? Demand a refund!
cthulhu is offline   Reply With Quote
Old 06-22-09, 09:41 AM   #5
Registered User
Join Date: Jun 2009
Posts: 4
Default Re: New breakage from Linus (nv-i2c.c)

darkmag is offline   Reply With Quote

Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump

All times are GMT -5. The time now is 11:03 PM.

Powered by vBulletin® Version 3.7.1
Copyright ©2000 - 2015, Jelsoft Enterprises Ltd.
Copyright 1998 - 2014, nV News.