Go Back   nV News Forums > Linux Support Forums > NVIDIA Linux

Newegg Daily Deals

Reply
 
Thread Tools
Old 06-15-10, 07:19 PM   #1
Anssi
Mageia packager
 
Join Date: Mar 2005
Location: Tampere, Finland
Posts: 45
Send a message via MSN to Anssi
Default [PATCH] Fix parameter ordering in acpi_walk_namespace

Hi!

The NV_ACPI_WALK_NAMESPACE is expanded wrongly on 2.6.33+, as originally noted by Yuval Hager in Gentoo #301318.

This is still the case with latest stable & beta releases, 195.36.31 and 256.29.

Attached is the patch from our tree.
__________________
Anssi Hannula (anssi@mageia.org)
Mageia packager of NVIDIA drivers
XBMC developer
Anssi is offline   Reply With Quote
Old 06-15-10, 08:59 PM   #2
ShiningArcanine
Registered User
 
Join Date: Aug 2006
Posts: 106
Default Re: [PATCH] Fix parameter ordering in acpi_walk_namespace

I believe you found the cause of an issue I was having trouble nailing down:

http://www.nvnews.net/vbulletin/showthread.php?t=151685

The irony here is that I am the person who filed the original bug report at the Gentoo Linux bug tracker where Yuval Hager noted this issue, and I did not realize that nvidia's developers had introduced this issue to newer versions of nvidia's drivers. To make matters worse, the Gentoo package maintainer for Nvidia's drivers appears to have been completely unaware of this issue and not only did this go unpatched in the newer versions of the nvidia drivers, but the bad patch which was circulated on nvnews.net a few months ago was introduced to Gentoo, despite an open bug report saying to do otherwise.

Thankyou for posting about this here. I filed a bug with the Gentoo bug tracker that I hope will result in having this fixed:

http://bugs.gentoo.org/show_bug.cgi?id=324197
ShiningArcanine is offline   Reply With Quote
Old 06-16-10, 10:15 AM   #3
zander
NVIDIA Corporation
 
zander's Avatar
 
Join Date: Aug 2002
Posts: 3,740
Default Re: [PATCH] Fix parameter ordering in acpi_walk_namespace

Thanks for reporting this problem. I'll fix the seven-argument version of NV_ACPI_WALK_NAMESPACE() for future driver releases.
zander is offline   Reply With Quote
Old 06-16-10, 10:38 AM   #4
zander
NVIDIA Corporation
 
zander's Avatar
 
Join Date: Aug 2002
Posts: 3,740
Default Re: [PATCH] Fix parameter ordering in acpi_walk_namespace

I should note that the current version should not really have functional fallout: in 195.36.xx release builds (i.e. without DEBUG #defined), NV_ACPI_WALK_NAMESPACE() is only invoked as follows:
NV_ACPI_WALK_NAMESPACE(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
ACPI_UINT32_MAX, nv_acpi_find_methods, NULL, NULL);
Given the current implementation of NV_ACPI_WALK_NAMESPACE() for Linux 2.6.33+, this translates to the following acpi_walk_namespace() call:
acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
ACPI_UINT32_MAX, nv_acpi_find_methods, NULL, NULL, NULL);
Since both the context and return_value arguments are NULL, the current and the fixed versions of NV_ACPI_WALK_NAMESPACE() expand to the same call.
zander is offline   Reply With Quote
Reply


Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump


All times are GMT -5. The time now is 08:33 PM.


Powered by vBulletin® Version 3.7.1
Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Copyright 1998 - 2014, nV News.