Segmention Fault with xine-vdpau and VDR

[wbreu]

Hello stephen,

the file-upload is running.

files named with my nick.

Is this now a nvidia-vdpau-problem or a xine-vdpau-problem?

Great Job!

Wolfgang

[Stephen Warren]

You wrote:

If you need the full log from the console of VDR/xine-vdpau (ca. 8 MB), no problem.

Could you upload this, or attach it (it should compress very well)? There's one thing I'd like to check. Thanks.

[Stephen Warren]

This is probably a xine bug.

I've decoded VDPAU's internal data structures, and found that there's at least one video surface allocated with size 1280x720 (VDPAU handle 4 in the core dump, which matches your earlier VDPAU_TRACE output). However, note that I also see handle 7, 8, 9, ... in VDPAU allocated as size 720x576.

If you look at your complete trace log, I suspect you'll find a vdp_video_surface_create call returning handle 4, with size parameters 1280x720. The allocation happens before the short log you uploaded starts.

Now, the vdp_video_surface_put_bits_y_cb_cr API doesn't specify the size of the data being uploaded to the surface. Instead, it requires that the application provide data that exactly matches the complete size of the surface. Hence, VDPAU is accessing 1280x720 pixels from the application data, but given the pitches xine is supplying, I guess there's only enough valid memory for 720x576 pixels to be read.

Hopefully, this is enough for the xine developers to look into the problem.

[crisalide]

Originally Posted by Stephen Warren

Now, the vdp_video_surface_put_bits_y_cb_cr API doesn't specify the size of the data being uploaded to the surface. Instead, it requires that the application provide data that exactly matches the complete size of the surface.

Ah, yes, soft_surface size update was only checking if (new_frame_size > current_frame_size).
r272 fixes that.

[wbreu]

Hello stephen,

many thanks for your debugging!

I think the upload of the full-log is not necassery, or you need it for other things?

@crisalide,thank you for the very quick fixing in xine-vdpau

Wolfgang

[Stephen Warren]

Yes, since crisalide confirmed/fixed the issue, there's no need for the full log.

[wbreu]

Hello crisalide,

i've installed r272, the fix is great, the segfault never comes ever more.

Wolfgang