GLSL extension to support D3D floating point rules?

machete143 · 06-12-11, 04:39 AM

Hi,
I would like to draw your attention to another StarCraft II issue which breaks ingame shaders: Bug 26967.
Would it be possible to implement the suggestion mentioned there?

mooninite · 06-12-11, 10:48 PM

I used the patch from comment 23 of this bug: http://bugs.winehq.org/show_bug.cgi?id=23906#c23 to fix the water and fog.

The current Wine behavior makes a campaign map in Starcraft 2 completely unplayable, even on Low settings, unless the patch is used.

It would be nice to see a statement from a GPU vendor on this. It may be a D3D bug, but I am not a D3D expert by any means.

machete143 · 06-13-11, 07:00 AM

Comment http://bugs.winehq.org/show_bug.cgi?id=23906#c30 is very informative, maybe there will be a ogl extension in the future which will fix a lot of games

Nephyrin · 06-13-11, 05:18 PM

Rather than a d3d behavior switch, a OpenGL extension that simply allowed you to define how floating point operations like 0.0 * INF are handled via a pragma would probably be more generic and useful in this case, yeah?

machete143 · 06-14-11, 08:00 AM

I think they actually fixed it in D3D but there are games which still expect the old behaviour, therefore the games must get fixed. But yes, i think an ogl extension would be enough

machete143 · 06-15-11, 06:18 AM

Quote:

Originally Posted by mooninite

I used the patch from comment 23 of this bug: http://bugs.winehq.org/show_bug.cgi?id=23906#c23 to fix the water and fog.

This patch did not fix the water for me. Which wine version did you apply the patch to?

mooninite · 06-15-11, 08:43 AM

Quote:

Originally Posted by machete143

This patch did not fix the water for me. Which wine version did you apply the patch to?

1.3.21

I have my shaders set to Medium. The water is not black (looks real-ish) and the Haven fog doesn't make the whole screen black. I can see buildings and units.

machete143 · 06-15-11, 09:18 AM

Oh I tried it only on high settings with 1.3.22, maybe it has to do something with the shader settings as there were some shaders which didn't work on high in the past

edit://
well I tried it now on medium shaders too, still doesn't work. The save haven mission is unplayable because the whole map is black even on lowest settings! tried it only with 1.3.22 tho

edit2://
but it works fine with 1.3.18 ^^

mooninite · 06-15-11, 05:46 PM

I only have mine set to Medium due to performance. My 9800 GTX+ is maxed out on anything higher, but it displays fine on higher settings.

machete143 · 06-26-11, 05:19 PM

a word from the devs?

Nephyrin · 06-27-11, 05:02 PM

I just got a GTX570 and it still is too laggy above medium - I'm guessing this is more wine's problem than nvidia though.

It would be nice if nvidia considered a gl extension to modify floating point rules, but until/unless they do, we either have broken SC2 or even slower SC2 if someone writes a patch to add special-case handling to every fp instruction in wine.

machete143 · 06-28-11, 11:42 AM

I have a GTX 570 too and I can run everything on "ultra" quite smoothly. The bottleneck in this case is your CPU, not GPU. Try overclocking your CPU if you have a sufficient cooling system.

06-12-11, 04:39 AM	#1
machete143 Registered User Join Date: May 2011 Posts: 11	GLSL extension to support D3D floating point rules? Hi, I would like to draw your attention to another StarCraft II issue which breaks ingame shaders: Bug 26967. Would it be possible to implement the suggestion mentioned there?

06-12-11, 10:48 PM	#2
mooninite Registered User Join Date: May 2006 Posts: 477	Re: GLSL extension to support D3D floating point rules? I used the patch from comment 23 of this bug: http://bugs.winehq.org/show_bug.cgi?id=23906#c23 to fix the water and fog. The current Wine behavior makes a campaign map in Starcraft 2 completely unplayable, even on Low settings, unless the patch is used. It would be nice to see a statement from a GPU vendor on this. It may be a D3D bug, but I am not a D3D expert by any means.

06-13-11, 07:00 AM	#3
machete143 Registered User Join Date: May 2011 Posts: 11	Re: GLSL extension to support D3D floating point rules? Comment http://bugs.winehq.org/show_bug.cgi?id=23906#c30 is very informative, maybe there will be a ogl extension in the future which will fix a lot of games

06-13-11, 05:18 PM	#4
Nephyrin Registered User Join Date: Apr 2007 Location: Simi Valley, CA Posts: 45	Re: GLSL extension to support D3D floating point rules? Rather than a d3d behavior switch, a OpenGL extension that simply allowed you to define how floating point operations like 0.0 * INF are handled via a pragma would probably be more generic and useful in this case, yeah?

06-14-11, 08:00 AM	#5
machete143 Registered User Join Date: May 2011 Posts: 11	Re: GLSL extension to support D3D floating point rules? I think they actually fixed it in D3D but there are games which still expect the old behaviour, therefore the games must get fixed. But yes, i think an ogl extension would be enough

06-15-11, 09:18 AM	#8
machete143 Registered User Join Date: May 2011 Posts: 11	Re: GLSL extension to support D3D floating point rules? Oh I tried it only on high settings with 1.3.22, maybe it has to do something with the shader settings as there were some shaders which didn't work on high in the past edit:// well I tried it now on medium shaders too, still doesn't work. The save haven mission is unplayable because the whole map is black even on lowest settings! tried it only with 1.3.22 tho edit2:// but it works fine with 1.3.18 ^^

06-15-11, 05:46 PM	#9
mooninite Registered User Join Date: May 2006 Posts: 477	Re: GLSL extension to support D3D floating point rules? I only have mine set to Medium due to performance. My 9800 GTX+ is maxed out on anything higher, but it displays fine on higher settings.

06-26-11, 05:19 PM	#10
machete143 Registered User Join Date: May 2011 Posts: 11	Re: GLSL extension to support D3D floating point rules? a word from the devs?

06-27-11, 05:02 PM	#11
Nephyrin Registered User Join Date: Apr 2007 Location: Simi Valley, CA Posts: 45	Re: GLSL extension to support D3D floating point rules? I just got a GTX570 and it still is too laggy above medium - I'm guessing this is more wine's problem than nvidia though. It would be nice if nvidia considered a gl extension to modify floating point rules, but until/unless they do, we either have broken SC2 or even slower SC2 if someone writes a patch to add special-case handling to every fp instruction in wine.

06-28-11, 11:42 AM	#12
machete143 Registered User Join Date: May 2011 Posts: 11	Re: GLSL extension to support D3D floating point rules? I have a GTX 570 too and I can run everything on "ultra" quite smoothly. The bottleneck in this case is your CPU, not GPU. Try overclocking your CPU if you have a sufficient cooling system.