bug spotted in 100.14.11 linux x86 installer

[Fallen-Angel]

the bug is very simple to explain : the installer doesn't work if it is run from a path containing spaces.
by "doesn't work" i mean it doesn't manage to compile the kernel module.

here is my nvidia-installer.log :

nvidia-installer log file '/var/log/nvidia-installer.log'
creation time: Sat Jul 28 00:33:19 2007

option status:
license pre-accepted : false
update : false
force update : false
expert : false
uninstall : false
driver info : false
precompiled interfaces : true
no ncurses color : false
query latest version : false
OpenGL header files : true
no questions : false
silent : false
no recursion : false
no backup : false
kernel module only : false
sanity : false
add this kernel : false
no runlevel check : false
no network : false
no ABI note : false
no RPMs : false
no kernel module : false
force SELinux : default
no X server check : false
force tls : (not specified)
X install prefix : (not specified)
X library install path : (not specified)
X module install path : (not specified)
OpenGL install prefix : (not specified)
OpenGL install libdir : (not specified)
utility install prefix : (not specified)
utility install libdir : (not specified)
doc install prefix : (not specified)
kernel name : (not specified)
kernel include path : (not specified)
kernel source path : (not specified)
kernel output path : (not specified)
kernel install path : (not specified)
proc mount point : /proc
ui : (not specified)
tmpdir : /tmp
ftp mirror : ftp://download.nvidia.com
RPM file list : (not specified)

Using: nvidia-installer ncurses user interface
-> License accepted.
-> There appears to already be a driver installed on your system (version: 100.
14.11). As part of installing this driver (version: 100.14.11), the existin
g driver will be uninstalled. Are you sure you want to continue? ('no' will
abort installation) (Answer: Yes)
-> No precompiled kernel interface was found to match your kernel; would you li
ke the installer to attempt to download a kernel interface for your kernel f
rom the NVIDIA ftp site (ftp://download.nvidia.com)? (Answer: Yes)
-> No matching precompiled kernel interface was found on the NVIDIA ftp site;
this means that the installer will need to compile a kernel interface for
your kernel.
-> Performing CC sanity check with CC="cc".
-> Performing CC version check with CC="cc".
-> Kernel source path: '/lib/modules/2.6.22.1/source'
-> Kernel output path: '/lib/modules/2.6.22.1/build'
-> Performing rivafb check.
-> Performing nvidiafb check.
-> Performing Xen check.
-> Cleaning kernel module build directory.
executing: 'cd ./usr/src/nv; make clean'...
rm -f -f nv.o nv-vm.o os-agp.o os-interface.o os-registry.o nv-i2c.o nvacpi.
o nv.o nv-vm.o os-agp.o os-interface.o os-registry.o nv-i2c.o nvacpi.o nvidi
a.mod.o
rm -f -f build-in.o nv-linux.o *.d .*.{cmd,flags}
rm -f -f nvidia.{o,ko,mod.{o,c}} nv_compiler.h *~
rm -f -f stprof stprof.o symtab.h Modules.symvers
rm -f -rf .tmp_versions
rm -f Makefile
-> Building kernel module:
executing: 'cd ./usr/src/nv; make module SYSSRC=/lib/modules/2.6.22.1/source
SYSOUT=/lib/modules/2.6.22.1/build'...
sh ./conftest.sh "cc" "cc" /lib/modules/2.6.22.1/source /lib/modules/2.6.22.
1/build cc_sanity_check full_output
sh ./conftest.sh "cc" "cc" /lib/modules/2.6.22.1/source /lib/modules/2.6.22.
1/build select_makefile full_output
make --no-print-directory -f Makefile module

NVIDIA: calling KBUILD...
make CC=cc KBUILD_OUTPUT=/lib/modules/2.6.22.1/build KBUILD_VERBOSE=1 -C /li
b/modules/2.6.22.1/source SUBDIRS=/home/fallen/Programmes/GeForce 8800 GTS/N
VIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv modules
make -C /lib/modules/2.6.22.1/build \
KBUILD_SRC=/usr/src/linux-2.6.22.1 \
KBUILD_EXTMOD="/home/fallen/Programmes/GeForce" -f /usr/src/linux-2.6.22.1/
Makefile 8800
test -e include/linux/autoconf.h -a -e include/config/auto.conf || ( \
echo; \
echo " ERROR: Kernel configuration is invalid."; \
echo " include/linux/autoconf.h or include/config/auto.conf are mis
sing."; \
echo " Run 'make oldconfig && make prepare' on kernel src to fix it
."; \
echo; \
/bin/false)
make[3]: *** Pas de règle pour fabriquer la cible « 8800 ». Arrêt.
make[2]: *** [8800] Erreur 2
NVIDIA: left KBUILD.
nvidia.ko failed to build!
make[1]: *** [module] Erreur 1
make: *** [module] Erreur 2
-> Error.
ERROR: Unable to build the NVIDIA kernel module.
ERROR: Installation has failed. Please see the file
'/var/log/nvidia-installer.log' for details. You may find suggestions
on fixing installation problems in the README available on the Linux
driver download page at www.nvidia.com.

i run the nvidia-installer script from this path : /home/fallen/Programmes/GeForce 8800 GTS/N VIDIA-Linux-x86-100.14.11-pkg1/

and we can see in the nvidia-installer.log this line :

make -C /lib/modules/2.6.22.1/build \
KBUILD_SRC=/usr/src/linux-2.6.22.1 \
KBUILD_EXTMOD="/home/fallen/Programmes/GeForce" -f /usr/src/linux-2.6.22.1/

so the KBUILD_EXTMOD variable isn't exact, it stops just before the space.

i just moved all the directory into my /home/fallen/, and using this path without any space it worked very well at the first try

So here is the bug, the nvidia-installer doesn't seem to be working if run from a path containing spaces.
it should be simple to fixe but i'm not a shell script programmer
Except this, and the fact that the driver contains binary closed source part, i like this driver which works quite well, thank you

best regards.

--
Fallen-Angel

[zander]

This looks like a KBUILD (the Linux kernel build system) bug.